Skip to content

feat: add keyboard shortcuts help overlay - #1206

Closed
tangmingxiu11-commits wants to merge 1 commit into
Commitlabs-Org:masterfrom
tangmingxiu11-commits:feature/keyboard-shortcuts-overlay
Closed

feat: add keyboard shortcuts help overlay#1206
tangmingxiu11-commits wants to merge 1 commit into
Commitlabs-Org:masterfrom
tangmingxiu11-commits:feature/keyboard-shortcuts-overlay

Conversation

@tangmingxiu11-commits

Copy link
Copy Markdown

Summary

  • add a typed keyboard shortcut registry used by the command palette binding and the new help overlay
  • mount a ? / Shift+/ shortcuts overlay in AppShellLayout while ignoring editable fields
  • document the shortcut registry, accessibility behavior, and usage in docs/KEYBOARD_SHORTCUTS.md

Closes #919

Verification

  • pnpm exec vitest run src/components/shell/KeyboardShortcutsOverlay.test.tsx src/components/shell/AppShellLayout.test.tsx src/hooks/tests/useCommandPalette.test.ts
  • pnpm exec eslint src/components/shell/AppShellLayout.tsx src/components/shell/AppShellLayout.test.tsx src/components/shell/KeyboardShortcutsOverlay.tsx src/components/shell/KeyboardShortcutsOverlay.test.tsx src/hooks/useCommandPalette.ts src/lib/shortcuts/shortcutRegistry.ts src/lib/shortcuts/index.ts
  • git diff --check

Notes

  • Full pnpm exec tsc --noEmit is currently blocked by pre-existing syntax errors in src/components/shell/SidebarSearch.test.tsx before it reaches this change.
  • Local install/test verification was run on Node 24 with engine-strict=false because this machine does not have the repo-requested Node 20 runtime available; the repo engine settings were not changed.

@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

@1nonlypiece

Copy link
Copy Markdown
Contributor

Hi @tangmingxiu11-commits, closing this for now — I don't see it linked to an issue that's assigned to you. Feel free to reopen (or open a fresh PR) once you're assigned to the issue it addresses.

@1nonlypiece 1nonlypiece reopened this Jul 24, 2026
@1nonlypiece

Copy link
Copy Markdown
Contributor

Hi @tangmingxiu11-commits, closing this for now — I don't see it linked to an issue that's assigned to you. Feel free to reopen (or open a fresh PR) once you're assigned to the issue it addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a keyboard-shortcuts help overlay triggered by "?" across the app shell

2 participants